Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add testing on phpstan 1 and 2 #3

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

bbrala
Copy link
Member

@bbrala bbrala commented Dec 5, 2024

Description

Add phpstan 1 and 2 testing in the matrix.

Motivation and context

We support 1 and 2 so we need to run tests and static aanlysis against that

How has this been tested?

CI and locally

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@bbrala bbrala force-pushed the feature/add-min-max-phpstan branch from 68a2666 to e29c341 Compare December 5, 2024 07:35
@bbrala bbrala merged commit 3c1b698 into master Dec 5, 2024
@bbrala bbrala deleted the feature/add-min-max-phpstan branch December 5, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant